> On Sept. 15, 2016, 1:29 a.m., Aleix Pol Gonzalez wrote:
> > Other than that, the patch LGTM.

Aleix, you coined the idea of implementing a simpler widget that provides just 
a list of PIDs with their command names and possible command lines, based on 
the `ps` command (and comparable to the one in Qt Creator). Do you still think 
it'd be a good idea to add such a feature to libksysguard?
(Here's as good a place to raise the idea as any)


> On Sept. 15, 2016, 1:29 a.m., Aleix Pol Gonzalez wrote:
> > processcore/helper.cpp, line 133
> > <https://git.reviewboard.kde.org/r/128909/diff/2/?file=476882#file476882line133>
> >
> >     `KAUTH_HELPER_MAIN` doesn't work on OS X?

Thanks for picking up on this, I'd forgotten to make a comment about it.

I think the macro does work, it's KAuth which currently doesn't seem to work 
for me. It also doesn't in my Linux build, btw, but there at least it gives 
some error output suggesting tries to use polkit and possibly even the 
processlist helper from my KDE4 desktop. 

The explicit implementation on OS X wasn't because of the macro, it was to 
allow running setuid root. Initial testing didn't show any benefit to that, but 
it could well be that's because KAuth still fails somewhere and then simply 
aborts the requested operation.

Suggestions very welcome, but if we can't get this to work I'll probably want 
to disable changing process priorities.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128909/#review99182
-----------------------------------------------------------


On Sept. 14, 2016, 9:37 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128909/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 9:37 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Software on Mac OS X.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> This patch implements initial and rather minimal support for OS X, for now 
> focussing purely on process information. That feature is justified as it is 
> used by KDevelop in order to obtain the list of processes one can attach a 
> debugger to.
> 
> Mac OS X is tricky because it requires special privileges in order to obtain 
> certain types of information for any running process. For example, even 
> obtaining the number of threads spawned by a foreign process requires 
> privileges that aren't trivial to set up. I've prepared the terrain, but also 
> implemented a fallback strategy that calls `ps` to be sure that crucial 
> information like the command name is available for all processes.
> 
> 
> Diffs
> -----
> 
>   processcore/CMakeLists.txt e7c9263 
>   processcore/Info.plist PRE-CREATION 
>   processcore/helper.cpp d54c8e1 
>   processcore/processes_darwin_p.cpp PRE-CREATION 
>   processcore/processes_local_p.cpp 2bc123f 
> 
> Diff: https://git.reviewboard.kde.org/r/128909/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Frameworks 5.24.0 and Qt 5.6.1
> 
> 
> File Attachments
> ----------------
> 
> Attach to Process widget in KDevelop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/14/47468811-58cb-40b8-a735-4dd86dce98e1__Screen_Shot_2016-09-14_at_17.38.22.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

Reply via email to