-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128909/
-----------------------------------------------------------

(Updated Sept. 17, 2016, 7:32 p.m.)


Review request for KDE Base Apps and KDE Software on Mac OS X.


Changes
-------

Fail with a nice error when trying to send a signal to processes belonging to 
another user.


Repository: libksysguard


Description
-------

This patch implements initial and rather minimal support for OS X, for now 
focussing purely on process information. That feature is justified as it is 
used by KDevelop in order to obtain the list of processes one can attach a 
debugger to.

Mac OS X is tricky because it requires special privileges in order to obtain 
certain types of information for any running process. For example, even 
obtaining the number of threads spawned by a foreign process requires 
privileges that aren't trivial to set up. I've prepared the terrain, but also 
implemented a fallback strategy that calls `ps` to be sure that crucial 
information like the command name is available for all processes.


Diffs (updated)
-----

  processcore/CMakeLists.txt e7c9263 
  processcore/Info.plist PRE-CREATION 
  processcore/helper.cpp d54c8e1 
  processcore/processes_darwin_p.cpp PRE-CREATION 
  processcore/processes_local_p.cpp 2bc123f 
  processui/ReniceDlg.cpp a97563f 
  processui/ksysguardprocesslist.cpp 44603de 

Diff: https://git.reviewboard.kde.org/r/128909/diff/


Testing
-------

On OS X 10.9.5 with Frameworks 5.24.0 and Qt 5.6.1


File Attachments
----------------

Attach to Process widget in KDevelop
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/14/47468811-58cb-40b8-a735-4dd86dce98e1__Screen_Shot_2016-09-14_at_17.38.22.png


Thanks,

René J.V. Bertin

Reply via email to