> On Sept. 19, 2016, 5:19 a.m., Rolf Eike Beer wrote: > > konqueror/src/CMakeLists.txt, line 18 > > <https://git.reviewboard.kde.org/r/128941/diff/1/?file=477131#file477131line18> > > > > If Konqueror directly uses these symbols it needs to explicitely link > > to it, even if libkonq does.
I don't see it though, and wrt linking there is no difference after my patch. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128941/#review99266 ----------------------------------------------------------- On Sept. 18, 2016, 11:36 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128941/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2016, 11:36 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Repository: kde-baseapps > > > Description > ------- > > Add ECMMarkAsTest, used by fsview tests > > > Diffs > ----- > > konqueror/CMakeLists.txt 53c4829cbc2f8b380ad8608b555eb6e15b24a3bb > konqueror/src/CMakeLists.txt e8e408611335fa56faf24466307f83e40a3b70ee > lib/konq/CMakeLists.txt 7a61493ff13561340c1a6c114763489343212f41 > > Diff: https://git.reviewboard.kde.org/r/128941/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sturmlechner > >
