> On Sept. 7, 2016, 9:49 a.m., Sebastian Kügler wrote: > > This patch seems to have caused a regression when installing some wallpaper > > packages, Marco fixed it in the knewstuff frameworks with > > 39b33ddd1e21c017b. We may have a problem now -- we'll have to fix Plasma 4? > > :/ > > Albert Astals Cid wrote: > a quick look on that commit, how is related to this one? they seem to be > touching different parts of the code > > Sebastian Kügler wrote: > Wallpaper packages were unzipped into the parent directory instead of > creating a subdirectory for the wallpaper. This commit caused this > regression, Marco's commit fixed it in knewstuff. (It should be relatively > easy to test, try installing my "Borneo Pink" wallpaper from the wallpaper > dialog in Plasma and look into ~/.local/share/wallpapers/ directory (with and > without patches). > > Albert Astals Cid wrote: > I'm going to be away from a computer for almost 3 weeks, make sure you > cotnact Andreas/David off this site (it's easy to ignore comments on already > submitted reviews) if they don't answer to try to get this fixed.
Was there any progress on this front? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128749/#review98968 ----------------------------------------------------------- On Aug. 25, 2016, 10:34 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128749/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 10:34 p.m.) > > > Review request for kdelibs, Andreas Cord-Landwehr and David Faure. > > > Repository: kdelibs > > > Description > ------- > > What the summary says > > > Diffs > ----- > > kdecore/io/karchive.cpp eb0bf2e > kdecore/tests/karchivetest.h e64e0ed > kdecore/tests/karchivetest.cpp 7786b98 > > Diff: https://git.reviewboard.kde.org/r/128749/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
