----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129208/#review100139 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Oct. 18, 2016, 10:13 a.m., Gerhard Gappmeier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129208/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 10:13 a.m.) > > > Review request for kdelibs and Thiago Macieira. > > > Repository: kdelibs > > > Description > ------- > > RFC3986 defines the following syntax for URI schemes > scheme = alpha *( alpha | digit | "+" | "-" | "." ) > > The '.' was missing which leaded to the problem that > xdg-open opc.tcp://localhost didn't work. > > Background: > xdg-open calls kde-open which then uses KUrl and so leaded to this > problem. Of course this bug may affect also many other locations > using KUrl::isRelativeUrl. > > This fix also adds a unit test to test the fix and avoid future > regressions. > > > Diffs > ----- > > kdecore/io/kurl.cpp d9661eab5f8df3bfbbd2900246437fb129037dba > kdecore/tests/kurltest.cpp 3947724bfd1d26ad69b97789205a814a8d712591 > > Diff: https://git.reviewboard.kde.org/r/129208/diff/ > > > Testing > ------- > > > Thanks, > > Gerhard Gappmeier > >
