> On Nov. 5, 2016, 10:30 p.m., Sandro Knauß wrote: > > these two changes look unreleaded to the patch. > > Antonio Rojas wrote: > No, these are required because they were pulled indirectly by kdepimlibs' > gpgme++, but not by gpgme's one.
Okay I see normally this line is added often by accident. - Sandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129339/#review100616 ----------------------------------------------------------- On Nov. 5, 2016, 9:35 a.m., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129339/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2016, 9:35 a.m.) > > > Review request for KDE Runtime and Andreas Sturmlechner. > > > Repository: kde-runtime > > > Description > ------- > > This patch, based on the one from the kwallet repo, allows building kwalletd > against the gpgme++ library provided by gpgme 1.7 instead of the kdepimlibs > one. > > > Diffs > ----- > > kwalletd/CMakeLists.txt 73aec82 > kwalletd/backend/CMakeLists.txt 4db348f > kwalletd/backend/backendpersisthandler.cpp b7f63f8 > kwalletd/kwalletwizard.cpp 78de78d > > Diff: https://git.reviewboard.kde.org/r/129339/diff/ > > > Testing > ------- > > Built: > 1) with kdepimlibs > 2) with no kdepimlibs and gpgme 1.7 > 3) with no kdepimlibs and no gpgme > > Builds correctly in all cases, links to the expected version of libgpgme++ in > the first two cases. In the first case there is no change in behaviour with > respect to the previous situation. > > > Thanks, > > Antonio Rojas > >
