El dimarts, 23 de maig de 2017, a les 10:17:46 CEST, Lays Rodrigues va escriure: > Good morning everyone, > For you that don't know me, I'm Lays Rodrigues, and I work with 3 more > guys(Patrick, Chris, Tomaz) on Atelier. > Atelier is a software for 3DPrinting that we are building inside KDE. So > far we have 10 months of work, and we are ready for the launch of our core, > in this case, is AtCore. > AtCore is the API responsible for all serial communication, and for > validating more of our work, we would like to launch the 0.1 version with > the next KDE Applications release.
You understand that if you are on extragear you don't get released with "KDE Applications", right? You need to do the release yourself. Also on a first look, it seems like you're missing some const in your getter functions (atcore.h seriallayer.h) Also in atcore.h i think it'd be safer if you move the enums inside the class? And well in atcore.h you have a TODO, but since you're aiming for a 0.1 i guess you can ship with that TODO :D Cheers, Albert > I was told that Extragear applications don't need to follow KDE releases, > but we thought that would be better to follow the release schedule on the > first launches, so we can fix, for us, a deadline. > So for this first step, we want to move AtCore from the Playground to > Extragear, and launch it with its test client, where we can make the core > stronger, so when we launch Atelier, we know that everything will be stable. > Our targets are all Gnu/Linux distros, and we already have inside Craft a > port for Windows with packing configured and working. > > Well, so I would like to require this review and moving to Extragear. > This is my first KDE application, so I maybe kind of lost. > > P.s: You can find more info about the status of the project on my blog here > <https://laysrodriguesdev.wordpress.com/category/atelier>. > > Thanks all, > > Ps.:2 I don't know if my first e-mail arrived, because I wasn't subscribed > to this mail list, if this is a duplicate, sorry.
