> On 九月 16, 2017, 9:19 a.m., Albert Astals Cid wrote: > > Are you sure this fixes anything? > > > > Just before the lines you changed we have > > > > > > if ( ! buttonTbl->item(number, 0) ) > > buttonTbl->setItem(number, 0, new QTableWidgetItem()); > > > > Which will create the item, no? > > > > Or is it because number is a negative value somehow?
no, It still NULL after that. I think because "btnx keyboard" is not a real joystick, so It may not accept any button. - TOM ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130245/#review103704 ----------------------------------------------------------- On 九月 16, 2017, 7:07 a.m., TOM Harrison wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130245/ > ----------------------------------------------------------- > > (Updated 九月 16, 2017, 7:07 a.m.) > > > Review request for kde-workspace. > > > Repository: plasma-desktop > > > Description > ------- > > This patch will fix the joystick config when detect "btnx keyboard" as > joystick, It will crash. > Due to Btnx keyboard is not a regular joystick. > Just add one more if to fix this crash. > > > Diffs > ----- > > kcms/hardware/joystick/joywidget.cpp 6007d867 > > > Diff: https://git.reviewboard.kde.org/r/130245/diff/1/ > > > Testing > ------- > > > Thanks, > > TOM Harrison > >
