Am Dienstag, 19. November 2019, 05:20:23 CET schrieb Alexander Potashev: > Hi, > > KTimeTracker [1] has been moved to kdereview.
Did some favourite-nitpicks review comments as direct fixes. Otherwise looks nice code on a quick superficial view. Needs other eyes though for proper review. You want to instruct the Messages.sh to just care for the src/ subdir, and there also exclude the test/ subdir (just in case and to speed up execution). Possibly first part can best be handled by moving Messages.sh into the src/ subdir. Cheers Friedrich