Thanks everyone for all the review feedback so far. With the exception of the variable length array comment, I think all feedback has been addressed. As for the variable length array, this will be gone when MR #24 lands: https://invent.kde.org/kde/keysmith/merge_requests/24
Keysmith has been in KDE review for over three weeks, so unless there is urgent new feedback that leaves the question: what is next? Thanks again for all your help and feedback making Keysmith much better! Regards, -Johan Ouwerkerk On Wed, Dec 18, 2019 at 3:51 PM Bhushan Shah <bhus...@gmail.com> wrote: > > Hello everyone! > > Keysmith (https://invent.kde.org/kde/keysmith) has been moved to > kdereview. > > Keysmith is a Two-factor code generator for Plasma Mobile and Desktop > and is using oath-toolkit for this purpose. User interface is written in > the kirigami. > > Thanks! > > -- > Bhushan Shah > http://blog.bshah.in > IRC Nick : bshah on Freenode > GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D