Neat! - clazy has some hints - you could probably use https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html for loggincategory.cpp/h? - for qml you should probably use Kirigami.Units.gridUnit*N instead of hardcoding sizes - the hardcoded colors also seem a bit of an odd choice - they are done already but for future reference you might want to prefer i18nc over i18n, in particular for single word string such as `i18n("Url:")` (which btw is also incorrectly capitalized) - talking about... TopMenuBar doesn't consistently use Title Capitalization - may be of interest to shove the raw journal pointer into a unique_ptr asap: https://invent.kde.org/plasma/drkonqi/-/blob/master/src/coredump/memory.h
On Sun, Oct 9, 2022 at 7:18 PM Andreas Cord-Landwehr <cordlandw...@kde.org> wrote: > > Hi, after a few releases over the past year, I would like to get KJournald > included in KDE application releases. This project is about providing both an > QItemModel abstraction library for the C-style journald API and providing an > efficient graphical browser for journald logs. > > Sysadmins moved the repository to KDE Review today, you can find the source > code here: > > https://invent.kde.org/libraries/kjournald > > (flatpack packaging is also available for easy trying it out) > > Even though KJournald is currently contained in the "libraries" playground > module, I would like to get it included in the "utilities" module after > passing KDE Review. The reason is that at the moment I more focus on the > application part and that is the most user-facing part. Having it in > "utilities" thus will avoid confusion. > > Looking forward for your review comments! > > Best regards, > Andreas > >
