On Wed, Nov 16, 2011 at 6:37 PM, Stephane MANKOWSKI <steph...@mankowski.fr> wrote: > Hi, > > 1-For some days, I have many new errors in krazy2 reports due to the check > named "Check for normalized SIGNAL and SLOT signatures [normalize]". > This check gives a link to > http://marcmutz.wordpress.com/effective-qt/prefer-to-use-normalised-signalslot-signatures. > > If I well understood, I have to replace this kind of signal: > SIGNAL( rowsInserted( const QModelIndex &, int, const int ) ) > by > SIGNAL(rowsInserted(QModelIndex,int,int)) > > 2-I also followed the recommendation given by TechBase style: > http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting > In this page, we can read that we can use the following astyle command: > > astyle --indent=spaces=4 --brackets=linux \ > --indent-labels --pad-oper --unpad-paren --pad-header \ > --keep-one-line-statements --convert-tabs \ > --indent-preprocessor \ > `find -type f -name '*.cpp'` `find -type f -name '*.cc'` `find -type f -name > '*.h'` > > The --pad-oper adds spaces and transforms: > SIGNAL(rowsInserted(QModelIndex,int,int)) > int > SIGNAL(rowsInserted(QModelIndex, int, int)) > > So, we have conflicting recommendations. > What do we have to do? > Follow krazy2 or astyle? > > Regards, > Stephane >
Looks like astyle doesn't know about QObject - normalized - signal/slot connection. use the krazy2 for the Qt documentation says that it's faster to call a signal / slot when it's normalized. >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe >>> << > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
