----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/#review46667 -----------------------------------------------------------
Well done. You're almost there. src/file/extractor/app.cpp <https://git.reviewboard.kde.org/r/114816/#comment33315> The signal is not connected to anything so it doesn't do much. Instead, you'll need to save all these "invalid documents" in a QVector<uint>, and then in App::saveChanges remove them from the xapian db. Have a look at how the commit queue removes them from the database. The code will be nearly identical. src/file/fileindexingjob.cpp <https://git.reviewboard.kde.org/r/114816/#comment33313> Ideally, I would have liked for this code which checks if the file exists to be moved to the extractor. Over there you check if the file does not exist and accordingly delete it from the xapian db. - Vishesh Handa On Jan. 2, 2014, 8:40 p.m., Benjamin Kaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114816/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 8:40 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Optimize Baloo indexing. > > GCI Task: > http://www.google-melange.com/gci/task/view/google/gci2013/5256301101711360 > > > Diffs > ----- > > src/file/extractor/main.cpp 9ac1f52 > src/file/extractor/app.cpp dba9c6f > src/file/extractor/app.h 6ea50a0 > src/file/indexscheduler.cpp 2adce55 > src/file/fileindexingqueue.cpp cb87e33 > src/file/fileindexingqueue.h 2fa98c8 > src/file/fileindexingjob.cpp 36ae22d > src/file/fileindexingjob.h 371c772 > > Diff: https://git.reviewboard.kde.org/r/114816/diff/ > > > Testing > ------- > > Ran baloo_file_extractor with both a known id and a url: > > $ baloo_file_extractor > /home/benkaiser/Documents/GCI/marble/doc/configsynchronization.html > baloo_file_extractor(26151)/kdecore (KSycoca) KSycocaPrivate::openDatabase: > Trying to open ksycoca from "/var/tmp/kdecache-benkaiser/ksycoca4" > baloo_file_extractor(26151) Result::add: "wordCount" QVariant(int, 581) > baloo_file_extractor(26151) Result::add: "lines" QVariant(int, 8) > baloo_file_extractor(26151) Result::add: "characterCount" QVariant(int, 3900) > $ baloo_file_extractor 226463 > > baloo_file_extractor(26234)/kdecore (KSycoca) KSycocaPrivate::openDatabase: > Trying to open ksycoca from "/var/tmp/kdecache-benkaiser/ksycoca4" > baloo_file_extractor(26234) Result::add: "wordCount" QVariant(int, 604) > baloo_file_extractor(26234) Result::add: "lines" QVariant(int, 1) > baloo_file_extractor(26234) Result::add: "characterCount" QVariant(int, 3895) > > > Thanks, > > Benjamin Kaiser > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
