----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117085/#review54200 -----------------------------------------------------------
Ship it! I know we're going to be releasing the first release candidate soon, and we're in API freeze, but this is a very trivial change, so please push it to KDE/4.13. This way your query parser can easily be used by others. - Vishesh Handa On March 26, 2014, 1:45 p.m., Denis Steckelmacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117085/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 1:45 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This patch adds two methods in Baloo::Term: setUserData and userData. They > can be used to associate arbitrary QVariants to terms. The data is not > serialized to JSON nor read back when the term is deserialized. > > The primary use of these two methods is to allow the user query parser to > store the position and length of terms. This information is then read back by > the query builder widget that uses it to syntax-highlight the queries. Other > applications may want to associate data with terms, for instance to pass > hints to the search stores. > > > Diffs > ----- > > src/core/term.cpp ec98c4a > src/core/term.h 23df3f1 > > Diff: https://git.reviewboard.kde.org/r/117085/diff/ > > > Testing > ------- > > The code compiles and all the unit tests of Baloo pass ("make test" in the > build directory lists 12 passing tests) > > > Thanks, > > Denis Steckelmacher > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
