----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/#review55461 -----------------------------------------------------------
src/file/kcm/folderselectionwidget.cpp <https://git.reviewboard.kde.org/r/117436/#comment38601> maybe QFileInfo(QDir::homePath()).absolutPath() src/file/kcm/folderselectionwidget.cpp <https://git.reviewboard.kde.org/r/117436/#comment38602> p is a rather bad variable name :) the question is what does this check protect against? Might be easier to check if "url" is a prefix of QDir::homePath() if this protects against $HOME being excluded - Kevin Krammer On April 8, 2014, 1 p.m., Lindsay Mathieson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117436/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 1 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Part of the KCM code assumes the users home dir is under "/home", which is > not always the cause in linux - e.g OpenSUSE with AD Authentication uses a > /home/DOMAIN hierarchy. Other systems use /opt. Not to mention windows etc. > > The code adds a function homeRoot() which returns the parent directory of the > uses home directory. > > > Diffs > ----- > > src/file/kcm/folderselectionwidget.cpp bc87a33 > > Diff: https://git.reviewboard.kde.org/r/117436/diff/ > > > Testing > ------- > > Built, installed. Adding paths to the exclude lists still recognise the home > root. > > > Thanks, > > Lindsay Mathieson > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
