----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118439/#review59205 -----------------------------------------------------------
Ship it! I wasn't too keen on having separate library names, but it does make distros lives much easier. Go ahead! And thanks for taking care of this. - Vishesh Handa On May 31, 2014, 11:59 a.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118439/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 11:59 a.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This turns baloo's libraries into a framework to make it coinstallable with > its KDE4 counterpart. > > As I've said in my first review request > (https://git.reviewboard.kde.org/r/118438/) I'm not exactly sure this is the > way you guys want to go, but I'd be willing to update my review request > accordingly if you have other plans to make it coinstallable. > > > Diffs > ----- > > BalooConfig.cmake.in d389bfd69def803b3bceb1a79ce4c97e4ea4803e > CMakeLists.txt fe6b24195eb39d9113004169bf119f4fe991e32b > src/core/CMakeLists.txt 844100f5e3ac9aebfb0d267f63742d63d2ad2965 > src/core/autotests/CMakeLists.txt d03b0a71848ea3a816d1d4c2ebcf1981e54ba710 > src/core/tests/CMakeLists.txt f505379c4b0da41c68e1945f3ae3b7ddccd57910 > src/file/lib/CMakeLists.txt 9bfafde198d5033bf1f1558aa7727d109b2c673d > src/file/lib/autotests/CMakeLists.txt > 0c20b65cf2302bdf1e39d9fc380fd371e699734e > src/xapian/CMakeLists.txt 5fcfd090ae479a8a79a37a3e6d0b6246d971a916 > > Diff: https://git.reviewboard.kde.org/r/118439/diff/ > > > Testing > ------- > > cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE .. > make > make install > > I've also built the frameworks branch of milou against it (needed a few > modifications). > > > Thanks, > > Heiko Becker > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
