----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119511/#review63314 -----------------------------------------------------------
No opinion on the patch but a few coding style issues, see below: src/kcommentwidget.cpp <https://git.reviewboard.kde.org/r/119511/#comment44138> Spaces between commas src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44131> Forward declare? You include it both in the .h and .cpp src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44132> Spaces between commas src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44134> Make const src/keditcommentdialog.h <https://git.reviewboard.kde.org/r/119511/#comment44133> Member variables should be prefixed with m_, also the asterisk goes after the space src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44137> Spaces between commas src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44136> buttonBox->addButton(i18n("Save"), QDialogButtonBox::AcceptRole); buttonBox->addButton(QDialogButtonBox::Cancel); That way you don't need to instantiate the button yourself. src/keditcommentdialog.cpp <https://git.reviewboard.kde.org/r/119511/#comment44135> Prefer compile-time checked connections: connect(buttonBox, &QDialogButtonBox::accepted, this, &QDialog::accept); - Kai Uwe Broulik On Juli 28, 2014, 9:26 vorm., Felix Eisele wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119511/ > ----------------------------------------------------------- > > (Updated Juli 28, 2014, 9:26 vorm.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo-widgets > > > Description > ------- > > I removed KDialog from kcommentwidget. I created a new class > keditcommentdialog. If this way is ok, I will do this for the other dialogs. > > > Diffs > ----- > > src/CMakeLists.txt 9b3a2d3 > src/kcommentwidget.cpp 00f69a9 > src/keditcommentdialog.h PRE-CREATION > src/keditcommentdialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119511/diff/ > > > Testing > ------- > > Tested in dolphin > > > Thanks, > > Felix Eisele > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
