-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120472/#review67861
-----------------------------------------------------------

Ship it!


Looks good.

- Vishesh Handa


On Oct. 3, 2014, 12:58 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120472/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 12:58 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Don't exit the file metadata fetching loop when no file indexing information 
> was found.
> 
> Only open the xapian database once and reuse it in FileFetchJob::doStart.
> 
> Still exits on "error: file doesn't exist" and "error: invalid id".
> 
> 
> Diffs
> -----
> 
>   src/file/lib/filefetchjob.cpp d91ea4e 
>   src/file/lib/filefetchjob.h 5d75f6e 
> 
> Diff: https://git.reviewboard.kde.org/r/120472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to