----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121266/#review71874 -----------------------------------------------------------
Ship it! Ship it. People are going to want to write all kinds of extractors. I probably shouldn't be a gatekeeper. If the property list grows too long, then we can find ways to only show relevant info. - Vishesh Handa On Nov. 27, 2014, 9:27 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121266/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 9:27 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > propertyinfotest iterates through all properties to make sure beginning > and end are set correctly and that all properties inbetween have a name > and description. > > this was not the case for new translation properties, making the test fail > > due to the nature of this test iterating through everything it would also > be very useful if the compiler warned about missing propertyinfos which > is achieved by not using a default case in the respective switch. > > also a note comment was added pointing out that an observent developer > adding a new entry also needs to add it in the fromName function. > > > Diffs > ----- > > src/propertyinfo.cpp 751f969eb9b71885323d5456ec7135874657db78 > > Diff: https://git.reviewboard.kde.org/r/121266/diff/ > > > Testing > ------- > > make & test > > > Thanks, > > Harald Sitter > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
