----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124016/#review81235 -----------------------------------------------------------
src/tools/balooctl/CMakeLists.txt (line 16) <https://git.reviewboard.kde.org/r/124016/#comment55631> This isn't needed as baloofilecommon links against it. src/tools/balooctl/indexer.cpp (line 43) <https://git.reviewboard.kde.org/r/124016/#comment55635> Please fetch the proper mimetype based on the data, not the extension. src/tools/balooctl/indexer.cpp (line 44) <https://git.reviewboard.kde.org/r/124016/#comment55637> The 'true' over here is super confusing. Maybe in another patch, you could change the 'bool' to an enum? src/tools/balooctl/indexer.cpp (line 51) <https://git.reviewboard.kde.org/r/124016/#comment55636> Please make this const, and use the c++11 for down below. src/tools/balooctl/main.cpp (line 267) <https://git.reviewboard.kde.org/r/124016/#comment55632> Please remove some of these empty lines. src/tools/balooctl/main.cpp (line 271) <https://git.reviewboard.kde.org/r/124016/#comment55638> Check if 'id > 0', it can be 0 if we cannot stat the file. src/tools/balooctl/main.cpp (line 272) <https://git.reviewboard.kde.org/r/124016/#comment55633> Coding style Also, this doesn't mean that the document is indexed. It just checks if the id is there in the file path db. That could mean it has just gone through the basic indexing, not the file. src/tools/balooctl/main.cpp (line 273) <https://git.reviewboard.kde.org/r/124016/#comment55634> out << url << " is ... - Vishesh Handa On June 5, 2015, 3:53 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124016/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 3:53 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This option will index the specified files (if they are not already in the > index) irrespctive of the the exclude prefrences or the hacks we have in > baloo_file_extractor (excluding text files over certain size, only indexing > text files with .txt extension etc). > > > Diffs > ----- > > src/tools/balooctl/CMakeLists.txt 524c208 > src/tools/balooctl/indexer.h PRE-CREATION > src/tools/balooctl/indexer.cpp PRE-CREATION > src/tools/balooctl/main.cpp bb35e5b > > Diff: https://git.reviewboard.kde.org/r/124016/diff/ > > > Testing > ------- > > 1. Ran balooctl index <filename> > 2. Searched for the indexed file through baloosearch > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
