----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124153/#review81839 -----------------------------------------------------------
Ship it! src/tools/baloo-monitor/main.qml (line 85) <https://git.reviewboard.kde.org/r/124153/#comment56173> I'm not sure what to do over here. We're supposed to be using i18n, and not qsTr, however, I'm not okay with the additional depdendency to KDeclarative for that. Just commit it for now, I guess. src/tools/baloo-monitor/main.qml (line 91) <https://git.reviewboard.kde.org/r/124153/#comment56174> Translate this please. - Vishesh Handa On June 25, 2015, 11:37 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124153/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 11:37 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Easier to use, provides compile time checks. > > > Diffs > ----- > > src/tools/baloo-monitor/CMakeLists.txt b80d129 > src/tools/baloo-monitor/main.qml 4b0de69 > src/tools/baloo-monitor/monitor.h 708ad6a > src/tools/baloo-monitor/monitor.cpp 9957424 > > Diff: https://git.reviewboard.kde.org/r/124153/diff/ > > > Testing > ------- > > Monitor works as before. Also watch for baloo to start and add a button to > monitor to start baloo (only shown if not running). > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
