> On July 3, 2015, 1:17 p.m., Stefan Brüns wrote: > > Hm, I think it is a good idea not to do the initial content indexer run on > > battery. For files added later the indexing should be done even on battery > > - the file is still in the cache, so no need to read it from disk, and > > there may be a long delay until the file gets indexed (My laptop runs 6-8 > > hours on battery and sometimes is not charged for several days, as is goes > > into suspend).
Sounds like a good idea, I think this can be simply acomplished by ignoring the battery state for the FileContentIndexer if number of files are below a certain threshold, but I'll probably do that in a seperate patch. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124240/#review82036 ----------------------------------------------------------- On July 3, 2015, 9:22 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124240/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 9:22 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > FileContentIndexer runs only when not on battery. Doesn't take into acount if > the PC is idle or not, yet. > > > Diffs > ----- > > src/file/fileindexscheduler.h f67aab7 > src/file/fileindexscheduler.cpp f388d3e > > Diff: https://git.reviewboard.kde.org/r/124240/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
