----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124610/#review83440 -----------------------------------------------------------
Ship it! definitely a "good thing" for private libraries (without public api). - Rex Dieter On Aug. 4, 2015, 8:04 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124610/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 8:04 a.m.) > > > Review request for Baloo, Build System and KDE Frameworks. > > > Repository: baloo > > > Description > ------- > > please note that the private target is appearing in the resulting cmake > config all the same and we cannot prevent this because of a cmake oddity > Alex Merry was kind enough to track down [1]. > testing suggests that this is however not breaking anything (what with the > library being private). > > [1] http://public.kitware.com/pipermail/cmake-developers/2015-July/025798.html > > > Diffs > ----- > > src/engine/CMakeLists.txt 8e2b5b9c0294a08142f4dc486eecab442167b1ec > > Diff: https://git.reviewboard.kde.org/r/124610/diff/ > > > Testing > ------- > > make && make install > no .so symlink installed > > made sure there is no symlink on the system and rebuilt gwenview: > gwenview builds just fine > > > Thanks, > > Harald Sitter > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
