> On Sept. 23, 2015, 2:08 p.m., Vishesh Handa wrote: > > Maybe you could split this into one patch where you remove the monitor and > > one in which you introduce the experimental qml monitor.h? > > > > Feel free to ship the one where you remove it.
We've introduced the experimental monitor already in a previous commit, so splitting this commit won't make sense. I can probably make the commit more descriptive stating we still keep some stuff for the experimental baloo monitor plugin. > On Sept. 23, 2015, 2:08 p.m., Vishesh Handa wrote: > > src/qml/experimental/monitor.cpp, line 140 > > <https://git.reviewboard.kde.org/r/125359/diff/1/?file=405112#file405112line140> > > > > This should use the locale way of formatting durations. Maybe in > > another patch? Yeah, that's already on my list. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85824 ----------------------------------------------------------- On Sept. 23, 2015, 1:11 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125359/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 1:11 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Since we have the monitor as KCM in KInfoCenter now no point keeping it in 2 > places. > > > Diffs > ----- > > src/qml/experimental/CMakeLists.txt d0f5481 > src/qml/experimental/baloomonitorplugin.cpp 1997782 > src/qml/experimental/monitor.h PRE-CREATION > src/qml/experimental/monitor.cpp PRE-CREATION > src/tools/CMakeLists.txt 7e5da67 > src/tools/baloo-monitor/CMakeLists.txt 4c8ac67 > src/tools/baloo-monitor/constants.js 2e8f26a > src/tools/baloo-monitor/main.cpp 9f108ea > src/tools/baloo-monitor/main.qml 01dfc3f > src/tools/baloo-monitor/monitor.h a864511 > src/tools/baloo-monitor/monitor.cpp 0b205d9 > src/tools/baloo-monitor/qml.qrc afd9e4c > > Diff: https://git.reviewboard.kde.org/r/125359/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
