----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/#review85859 -----------------------------------------------------------
Ship it! Ship It! - Pinak Ahuja On Sept. 23, 2015, 6:43 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125365/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 6:43 p.m.) > > > Review request for Baloo, Pinak Ahuja and Igor Poboiko. > > > Repository: baloo > > > Description > ------- > > When composing different PostingIterators in an AND / OR / PHRASE > combination, we should not ignore the null posting iterators. In the > case of AND that clearly implies that there is no result. > > We were just ignoring them and therefore returning invalid results. > > > Diffs > ----- > > autotests/unit/engine/andpostingiteratortest.cpp 9a71ae4 > autotests/unit/engine/orpostingiteratortest.cpp df0bd77 > autotests/unit/engine/phraseanditeratortest.cpp 6465a1e > src/engine/andpostingiterator.h d8aadec > src/engine/andpostingiterator.cpp 99b0b9b > src/engine/orpostingiterator.cpp 9d16349 > src/engine/phraseanditerator.h 1f5573e > src/engine/phraseanditerator.cpp d00cdcf > src/engine/transaction.cpp ad43d69 > src/lib/searchstore.cpp 806ea5f > > Diff: https://git.reviewboard.kde.org/r/125365/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
