> On Сен. 24, 2015, 11:50 п.п., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165>
> >
> > Have a look at basicindexingjob.txt. We define that all Presentation
> > and Spreadsheets are also Documents.
> >
> > For text, we specifically don't do that, as then we get source code as
> > Documents. Maybe we can make another category caleld "Source Code" or
> > something. I'm not sure, but just combining the two doesn't seem correct.
> >
> > Maybe others can chime in?
>
> Igor Poboiko wrote:
> Dammit, my fault. Sorry for the noise. I just noticed that sometimes
> KRunner don't look for presentations, so I thought the issue was here. And
> when I fixed it, it worked.
> But it seems like the problem is with indexing; sometimes mimetype is not
> determined correctly. And it's not always reproducible. But that's another
> issue.
>
> # balooctl index test.ppt
> Indexing /home/eol/test.ppt
> -- indexing "/home/eol/test.ppt" mimetype "application/x-ole-storage"
> File(s) indexed
> # mimetype test.ppt
> application/vnd.ms-powerpoint
>
> Regarding indexing of text files: I thought the issue was just due to
> performance of indexing; but now it doesn't index large text-files.
> I mean, e.g. I have a lot of plain-text documents (which are not source
> codes, but are proper documents): those are mostly LaTeX files or just .txt
> files with some notes. I expected them to pop up during search.
>
> Pinak Ahuja wrote:
> That would me mainly because we skip text files larger than 10 mb, have a
> look at file/extractor/app.cpp
> Maybe we can experiment with a different limit. Mimetype issue is
> something we should look into. I've seen audio files with .m4a extension
> showing mimetype as video in the index.
No-no, that wasn't the case. My .tex-files are much smaller (several KBs), and
"balooshow -x" shows that they are indexed properly. They just don't popup
because of its type ("T8 Ttext" in index).
The limit solution looks perfectly fine for me. I mean, I don't write files of
size 10Mb+ by myself :)
They are 99.99% are not documents but just some machine-generated junk
(log-files, or something like that), and I don't want it to be indexed anyways.
But small text files might be useful for me. Especially if they are already
indexed :)
Talking about mimetypes: right, I had the same issue with mp4 audio-files too.
But it seems to be an upstream issue, mimetype handling is shared-mime-database
and Qt job...
- Igor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125369/#review85905
-----------------------------------------------------------
On Сен. 24, 2015, 7:18 д.п., Igor Poboiko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125369/
> -----------------------------------------------------------
>
> (Updated Сен. 24, 2015, 7:18 д.п.)
>
>
> Review request for Baloo and Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Small usability improvement: since presentations, spreadsheets and text files
> are also documents (at least, that's what I expect :) ), search for them in
> KRunner when "documents" category is checked.
>
>
> Diffs
> -----
>
> runners/baloo/baloosearchrunner.cpp 0023a11
>
> Diff: https://git.reviewboard.kde.org/r/125369/diff/
>
>
> Testing
> -------
>
> It just works: now I am able to find my LaTeX-files, various presentations,
> etc with KRunner.
>
>
> Thanks,
>
> Igor Poboiko
>
>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
