----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125431/#review86077 -----------------------------------------------------------
I'm discarding this patch as review 125362 does a better job at fixing all the issues. - Vishesh Handa On Sept. 27, 2015, 9:50 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125431/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2015, 9:50 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > WriteTransaction: Fix memory corruption issue > > In both these functions the QByteArrays are allocated from > QByteArray::fromRawData so that we avoid copies. They come from the LMDB > db which guarentees the memory will not be discarded as long as we are > using it. Unfortunately for us, we mark it for remove in removeTerms and > replaceTerms after this call, so LMDB is free to reuse that memory, and > it probably does. > > We should ideally replace QByteArray with our ByteArray class. > > This does not fix all our issues. We still have problems. > > > Diffs > ----- > > src/engine/writetransaction.cpp 1391ba9 > > Diff: https://git.reviewboard.kde.org/r/125431/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
