----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/#review88751 -----------------------------------------------------------
Ship it! src/engine/database.cpp (line 73) <https://git.reviewboard.kde.org/r/126110/#comment60854> Please remove the comment. It's not longer valid. src/engine/database.cpp (line 192) <https://git.reviewboard.kde.org/r/126110/#comment60855> Perhaps you want to close the env here as well? The assert can fail in production. - Vishesh Handa On Nov. 19, 2015, 11:39 a.m., Boudhayan Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126110/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 11:39 a.m.) > > > Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. > > > Bugs: 353757 > http://bugs.kde.org/show_bug.cgi?id=353757 > > > Repository: baloo > > > Description > ------- > > * Add checks for failures > * Add manual checks after Q_ASSERT* (they're not compiled in Release mode) > * Clean up m_env after failure, not just set it to 0 > > > Diffs > ----- > > src/engine/database.cpp e39eb86 > > Diff: https://git.reviewboard.kde.org/r/126110/diff/ > > > Testing > ------- > > Builds, runs, does not crash. > make test succeeds at 100% > > > Thanks, > > Boudhayan Gupta > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
