----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126132/#review88752 -----------------------------------------------------------
Ship it! src/widgetfactory.cpp (line 118) <https://git.reviewboard.kde.org/r/126132/#comment60856> Perhaps use QStringLiteral instead? - Vishesh Handa On Nov. 22, 2015, 2:26 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126132/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2015, 2:26 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo-widgets > > > Description > ------- > > Bitrate can be better formatted. > > Now it's either a strange double number (3.00594e+06), or a long integer > (320000). > > > Diffs > ----- > > src/widgetfactory.cpp 7151952 > > Diff: https://git.reviewboard.kde.org/r/126132/diff/ > > > Testing > ------- > > Now 3.00594e+06 is displayed as 3.0 MB/s. > 320000 is displayed as 320 kB/s. > > > Thanks, > > Xuetian Weng > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
