> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > <https://git.reviewboard.kde.org/r/127178/diff/2/?file=445825#file445825line53> > > > > The test needs to be fixed. What exactly are the wierd moc errors you > > are getting? Lets find out why thats happening and try fixing them. Just > > comparing the size is not a decent test. > > Varun Joshi wrote: > https://paste.kde.org/phqjgjxo4 : This is what I get. I had asked around > earlier but hadn't found a solution then, so size was a stopgap measure > > Boudhayan Gupta wrote: > I see the problem - you're directly loading the taglibwriter class, which > is built as a plugin. > > The appropriate way to write this test would be to use only the public > API and let KFM load the taglib writer in its own course of execution. > > Pinak Ahuja wrote: > I think the problem is: trying to compile two plugin classes > (taglibreader, and taglibwriter) in one binary. Just compile the writer > directly and load the reader as a plugin from KFM or maybe directly using > QPluginLoader.
Yup, makes sense. On it. - Varun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/#review92981 ----------------------------------------------------------- On Feb. 28, 2016, 2:26 p.m., Varun Joshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127178/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 2:26 p.m.) > > > Review request for Baloo, Boudhayan Gupta, Pinak Ahuja, and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > 1. Added the Writer class similar to the Extractor class > 2. Added the WriteData class that works like an ExtractionResult > 3. Added WriterPlugin and WriterCollection that work similar to > ExtractorPlugin and ExtractorCollection > > > Diffs > ----- > > README.md 19b1a26a241e6a35c636aaf8162afe762018f073 > autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 > autotests/taglibwritertest.h PRE-CREATION > autotests/taglibwritertest.cpp PRE-CREATION > src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 > src/writedata.h PRE-CREATION > src/writedata.cpp PRE-CREATION > src/writer.h PRE-CREATION > src/writer.cpp PRE-CREATION > src/writer_p.h PRE-CREATION > src/writercollection.h PRE-CREATION > src/writercollection.cpp PRE-CREATION > src/writerplugin.h PRE-CREATION > src/writerplugin.cpp PRE-CREATION > src/writers/CMakeLists.txt PRE-CREATION > src/writers/taglibwriter.h PRE-CREATION > src/writers/taglibwriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127178/diff/ > > > Testing > ------- > > > Thanks, > > Varun Joshi > >
