----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127368/#review93485 -----------------------------------------------------------
src/writers/externalwriters/pdfwriter/main.py (line 1) <https://git.reviewboard.kde.org/r/127368/#comment63743> Please explicitly select python2 or python3, e.g. "#!/usr/bin/python2". - Alexander Potashev On Март 13, 2016, 11:16 п.п., Varun Joshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127368/ > ----------------------------------------------------------- > > (Updated Март 13, 2016, 11:16 п.п.) > > > Review request for Baloo, Boudhayan Gupta and Pinak Ahuja. > > > Repository: kfilemetadata > > > Description > ------- > > 1. Added an ExternalWriter Class that helps load plugins > 2. Modify WriterCollection to include external writers > 2. Added a pdfwriter that is written in Python. > > > Diffs > ----- > > src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 > src/externalwriter.h PRE-CREATION > src/externalwriter.cpp PRE-CREATION > src/writercollection.cpp PRE-CREATION > src/writers/CMakeLists.txt PRE-CREATION > src/writers/externalwriters/CMakeLists.txt PRE-CREATION > src/writers/externalwriters/pdfwriter/main.py PRE-CREATION > src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127368/diff/ > > > Testing > ------- > > > Thanks, > > Varun Joshi > >
