> On Aug. 19, 2016, 8:52 a.m., Vishesh Handa wrote: > > Could you please attach some screenshots of the before and after? > > James Smith wrote: > I don't think it's really necessary, the existing indexed tag was erased > if a tag higher up was selected, or an expanded first-level indexed tag > became unexpanded when erasing an unsaved new tag beyond the last item of the > indexed tag.
I cannot visaulize how this looks by just reading at the code. Please add images. Otherwise I need to compile this code and try it out manually. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128665/#review98495 ----------------------------------------------------------- On Aug. 19, 2016, 12:05 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128665/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2016, 12:05 a.m.) > > > Review request for Baloo. > > > Bugs: 334615 > http://bugs.kde.org/show_bug.cgi?id=334615 > > > Repository: baloo-widgets > > > Description > ------- > > Info pane tags are shortened to their last element, with the full tag shown > in each tag's tooltip. The tag selector box allows for creating and selecting > nested tags. > > > Diffs > ----- > > src/kedittagsdialog.cpp 1778d53 > src/kedittagsdialog_p.h 3c4de19 > src/tagcheckbox.cpp 8273a7f > > Diff: https://git.reviewboard.kde.org/r/128665/diff/ > > > Testing > ------- > > Compile, run > > > Thanks, > > James Smith > >
