> On Nov. 23, 2016, 2:41 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 71 > > <https://git.reviewboard.kde.org/r/129549/diff/1/?file=486480#file486480line71> > > > > Variables in cmake are case-sensitive. It should be the same as what > > you pass to find_package: `${Inotify_FOUND}`. > > > > (if that's not what the Find*.cmake file is doing, I'd consider it a > > bug)
You're right .. and it isn't, so I'll comment on the review for the Find(Lib)Inotify module as well and update this one later. - Adriaan de ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129549/#review101073 ----------------------------------------------------------- On Nov. 23, 2016, 2:06 p.m., Adriaan de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129549/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 2:06 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > Don't just assume that Linux has inotify and nobody else does. Instead, check > for inotify on non-Linux systems and if found, use it. > > This depends on https://git.reviewboard.kde.org/r/129316/ to actually get the > Inotify cmake-module. > > > Diffs > ----- > > CMakeLists.txt 299509c6bd113c7d78ebdae3806bdd2fb0077fad > src/file/CMakeLists.txt 767e7dc62e8f15e4ce545becc0a32a0d038dda69 > > Diff: https://git.reviewboard.kde.org/r/129549/diff/ > > > Testing > ------- > > This way, FreeBSD (which gets inotify support through libinotify) finds > inotify, enables support for it, and then builds all the bits of baloo that > depend on inotify. This is already done in the FreeBSD packaging. > > > Thanks, > > Adriaan de Groot > >
