Thank you Nate and Johannes for your positive feedback. If there are no
further complaints / comments, I'll edit the Commit Policy wiki page
tomorrow and add the points I listed below.
Cheers,
Julian / xyquadrat
On 18.09.20 10:05, Julian / xyquadrat wrote:
Hi all,
A few months back I suggested on behalf of the Promo team the
introduction of a new label for issues and merge requests (see
https://marc.info/?t=158695327000009&r=1&w=2 for the thread).
The idea behind this "Noteworthy" label was to make it easier for
Promo to keep up with all important new changes that are coming up in
our software and reduce the possibility that something noteworthy gets
overlooked.
Since then, the GitLab migration has been completed and such a label
has actually been introduced (see
https://invent.kde.org/dashboard/merge_requests/?scope=all&label_name[]=Noteworthy
for an overview of Merge Requests tagged with "Noteworthy").
Given that the technical challenge is now solved, I'd like to propose
to make this Noteworthy label official in the sense of adding it to
the "Special keywords" section of Commit Policy (if there is a more
appropriate place, please suggest it!) and encourage all contributors
to start using it.
A few remarks:
- Of course all contributions are noteworthy and important. Promo does
not want to discount the work that goes into small and unnoticeable fixes.
- If you are not sure whether a MR or issue should be "Noteworthy" or
not, tag it with "Noteworthy" (-> be liberal with the label usage).
Promo will then consider such edge cases in detail.
- Not all things tagged might make it into an official announcement.
This is (usually) not due to us overlooking them, but because we have
to carefully prioritize what we include. If you think something was
left out that should definitely have been included, reach out to us on
#kde-promo and we will be happy to discuss individual cases and solutions.
*Examples of noteworthy changes:*
* User facing feature additions (e.g. /New useful effect added to
Kdenlive/)
* Big changes in UI (e.g. /a KCM is rewritten in QML and now looks
distinctively different/)
* Long-standing, annoying bugs (e.g. /Rework of the previously
bug-ridden MTP implementation in KIO/)
* Large technology shifts (e.g. /Port to Qt 6/)
* Significant performance improvements (best paired with concrete
numbers, but not necessary)
*Examples of changes not considered noteworthy: *
* Small UX annoyances and fixes. Whilst those add up to something
very important, the individual changes (e.g. "more consistent
padding in dialogs") are not interesting to users.
* Shifts in technology that do not affect the behavior of the
product (e.g. /porting from library X version Y to library X
version Y+1/)
* Minor changes to tools and backends used in the development process
Feedback and criticism is much appreciated.
Cheers and have a nice day,
Julian / xyquadrat
