----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115956/#review50573 -----------------------------------------------------------
Generally looks good. Just a couple of things to fix. CMakeLists.txt <https://git.reviewboard.kde.org/r/115956/#comment35569> DESCRIPTION and URL should go in the FindDocBookXML4.cmake file cmake/FindDocBookXML4.cmake <https://git.reviewboard.kde.org/r/115956/#comment35570> Add something about how the version handling works - ie: pass a version to find_package(), and it will find that DTD version, otherwise it will find 4.2. - Alex Merry On Feb. 22, 2014, 6:19 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115956/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 6:19 p.m.) > > > Review request for Documentation and KDE Frameworks. > > > Repository: kdoctools > > > Description > ------- > > This is the combination of two RR, now that > FindDocBookXML.cmake/FindDocBookXSL.cmake have been moved to kdoctools: > - https://git.reviewboard.kde.org/r/115876/ > - https://git.reviewboard.kde.org/r/115879/ > > Combination of three commits: > 1) More generic structure for FindDocBookXML > > - allows modules to request a generic version of DocBook XML > - keep compatibility variables for now > (originally from 115876) > ------------------- > 2) Rename as FindDocBookXML4, it will be used only for DocBook 4.x > > The rename reflects the fact that it is used for DocBookXML4 only; > a future DocBookXML5 could be added if needed. > (originally from 115876) > > Use the new module name in CMake files. > (originally from 115879) > -------------------- > 3) New DocBookXML4_* variables, explicitly require the DocBookXML4 version > (originally from 115879) > > > Diffs > ----- > > CMakeLists.txt 5ad7099 > cmake/FindDocBookXML.cmake b6d623e > cmake/FindDocBookXML4.cmake PRE-CREATION > config-kdoctools.h.cmake f2fe22c > src/CMakeLists.txt 71a7d2e > src/customization/dtd/kdex.dtd.cmake c643d9b > > Diff: https://git.reviewboard.kde.org/r/115956/diff/ > > > Testing > ------- > > Compiles, documentation is generated. > > > Thanks, > > Luigi Toscano > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20140223/8d4f7153/attachment.html>
