----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127841/#review95258 -----------------------------------------------------------
Fix it, then Ship it! I did a quick review, and all in all it looks good to me. There are still some FIXME's, but I think it's fine to commit in this state, since it is already a huge improvement - Thanks! doc/kate/configuring.docbook (line 150) <https://git.reviewboard.kde.org/r/127841/#comment64614> Please capitalize: Session Elements. This is currently a i18n style guide bug which I just fixed in master, and commit request for the 16.04 branch is pending. doc/kate/fundamentals.docbook (line 269) <https://git.reviewboard.kde.org/r/127841/#comment64615> Show Proje_c_ts doc/kate/fundamentals.docbook (line 683) <https://git.reviewboard.kde.org/r/127841/#comment64616> I think this is still valid, but I am uncertain this is really helpful to users. Old-style only was relevant from KDE3 to KDE4. Therefore, the described workflow here is old, and users most certainly cannot benefit from this section. I would be fine with removing it. doc/kate/menus.docbook (line 815) <https://git.reviewboard.kde.org/r/127841/#comment64617> Activates the next tab in the tabbar. doc/kate/menus.docbook (line 828) <https://git.reviewboard.kde.org/r/127841/#comment64618> Activates the previous tab in the tabbar. doc/kate/menus.docbook (line 951) <https://git.reviewboard.kde.org/r/127841/#comment64619> This hides all split views except the currently active one. doc/kate/menus.docbook (line 1691) <https://git.reviewboard.kde.org/r/127841/#comment64620> Hm, it seems so, yes. I don't know why. - Dominik Haumann On May 5, 2016, 9:38 a.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127841/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 9:38 a.m.) > > > Review request for Documentation and Kate. > > > Repository: kate > > > Description > ------- > > Sync kate docbook with https://git.reviewboard.kde.org/r/127601/ Remove > Editor Component Extensions from katepart > Sync menus > > > Diffs > ----- > > doc/kate/configuring.docbook 444e625 > doc/kate/development.docbook 1c70411 > doc/kate/fundamentals.docbook f016585 > doc/kate/index.docbook 3aad430 > doc/kate/menus.docbook 789d9aa > doc/kate/plugins.docbook 605d867 > > Diff: https://git.reviewboard.kde.org/r/127841/diff/ > > > Testing > ------- > > passes checkXML5 > > > Thanks, > > Burkhard Lück > >
_______________________________________________ kde-doc-english mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-doc-english
