Burkhard Lück ha scritto: > Hi, > > if I file a review request for docbooks I always add two groups/devels as > reviewers: > > 1) group docs to check for conformity with docbook rules, wording, markup etc. > > 2) devel group or persons to check the technical aspect + feature correctness > in the update. > > Adding two different groups/persons to the RR I expect to get an OK="Ship It" > from both groups for the different aspects of the review ;-). > > If I get first a "Ship It" from a docs group member and the RR is only about > docbook related issues I usually commit, but not in case the RR is about > behavioral/feature changes, then I' need to have a confirmation from a > developer.
Right. > The other way round (first a "Ship It" from a devel group member) I am always > unsure how to handle that. > Do you think there is already a "Ship It" for the RR, no need to add an OK > from groups docs and I should just wait x days to commit or should I expect > an > explicit "Ship It" from the group docs? I would go and commit; at most. I would expect few days and commit (a "Ship it" from a developer of the application should mean that the content is accurate). Ciao -- Luigi _______________________________________________ kde-doc-english mailing list kde-doc-english@kde.org https://mail.kde.org/mailman/listinfo/kde-doc-english