----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128378/#review98244 -----------------------------------------------------------
doc/index.docbook (line 66) <https://git.reviewboard.kde.org/r/128378/#comment66177> This only works if kwallet_pam is installed (and properly configured). On certain distros (e.g. archlinux) it's not installed by default, so maybe this should be mentioned. doc/index.docbook (lines 194 - 195) <https://git.reviewboard.kde.org/r/128378/#comment66179> Not part of your diff, but here I would mention that an open wallet can be read by any user process (so this may be a security issue). See my mail on the recent thread on kde-devel: https://mail.kde.org/pipermail/plasma-devel/2016-July/056102.html doc/index.docbook (line 351) <https://git.reviewboard.kde.org/r/128378/#comment66178> typo: archiv -> archive - Elvis Angelaccio On July 9, 2016, 1:04 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128378/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 1:04 p.m.) > > > Review request for Documentation, KDE Utils and Valentin Rusu. > > > Repository: kwalletmanager > > > Description > ------- > > remove header entities already in kdoctools > bump date + releaseinfo > new screenshots > add info about default wallet kdewallet > add encrypted import + export, remove obsolete "Save as" > correct location of .kwl file > remove systen tray icons, not shown by default any longer > remove commented section about ksecrets > remove dead link to techbase > > > Diffs > ----- > > doc/application-request-to-open-wallet.png 819eb1a > doc/error-nokey.png 39a1e56 > doc/first-open-request.png 1940dbc > doc/index.docbook 19ea337 > doc/key-selection.png 8cfa1ee > doc/kwallet-applications.png 1ddf61d > doc/kwallet-edit.png 3cd865f > doc/kwalletmanager.png f7f2714 > doc/openwallet-request.png 7d4c62c > doc/save-login-information.png 5948bc9 > doc/wallet-encryption-selection.png 040d417 > > Diff: https://git.reviewboard.kde.org/r/128378/diff/ > > > Testing > ------- > > builds > > > Thanks, > > Burkhard Lück > >
