----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128678/#review98389 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 15, 2016, 12:41 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128678/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 12:41 a.m.) > > > Review request for Documentation, KDE Frameworks and David Faure. > > > Repository: kjs > > > Description > ------- > > The kjs man page is translated, so install the translations if available. > > > Diffs > ----- > > CMakeLists.txt 450c2b7 > > Diff: https://git.reviewboard.kde.org/r/128678/diff/ > > > Testing > ------- > > Compiled with and without the po/ directory as in the tarball. > > Side note: we probably don't need the pattern like > if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") > ... > endif() > > around ki18n_install and kdoctools_install, as they rely on a glob which, if > empty, simply lead to no actions. > > > Thanks, > > Luigi Toscano > >
