----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100526 -----------------------------------------------------------
KF5DocToolsMacros.cmake (line 150) <https://git.reviewboard.kde.org/r/129314/#comment67488> Doesn't cmake already do this expansion itself? What error are you trying to fix? src/checkXML5.cpp (line 35) <https://git.reviewboard.kde.org/r/129314/#comment67489> Reading the documentation these two versions do the exact same thing. - Aleix Pol Gonzalez On Nov. 2, 2016, 8:55 p.m., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 8:55 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > ------- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > ----- > > KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > ------- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
