----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128912/#review100793 -----------------------------------------------------------
Ship it! Then let's go for it. We have 3 weeks until the next Frameworks release to fix it, in case. - Luigi Toscano On Nov. 11, 2016, 4:39 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128912/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 4:39 p.m.) > > > Review request for Documentation, KDE Frameworks and Plasma. > > > Repository: kio > > > Description > ------- > > doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent > doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ > doc/kcontrol/ebrowsing/ doc/kcontrol/smb/ > splitted from kde-runtime master using https://github.com/ajdruff/git-splits > > Not included in build so far, the docbooks are imported as they were splitted > > To be done next: > Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, > rename ebrowsing to webshortcuts > reapply a few updates done in plasma-desktop > remove these imported kcontrol docbooks from plasma-desktop > adapt scripty to these changes > > > Diffs > ----- > > docs/CMakeLists.txt 350bce3 > docs/kcontrol5/CMakeLists.txt PRE-CREATION > docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION > docs/kcontrol5/cache/index.docbook PRE-CREATION > docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION > docs/kcontrol5/cookies/index.docbook PRE-CREATION > docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION > docs/kcontrol5/netpref/index.docbook PRE-CREATION > docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION > docs/kcontrol5/proxy/index.docbook PRE-CREATION > docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION > docs/kcontrol5/smb/index.docbook PRE-CREATION > docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION > docs/kcontrol5/trash/index.docbook PRE-CREATION > docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION > docs/kcontrol5/useragent/index.docbook PRE-CREATION > docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION > docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION > src/ioslaves/trash/kcmtrash.desktop c8ff4ac > src/kcms/kio/cache.desktop f0bd261 > src/kcms/kio/cookies.desktop f91b5cd > src/kcms/kio/netpref.desktop 963ef3f > src/kcms/kio/proxy.desktop c11451d > src/kcms/kio/smb.desktop c323614 > src/kcms/kio/useragent.desktop 856e9cc > src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a > > Diff: https://git.reviewboard.kde.org/r/128912/diff/ > > > Testing > ------- > > history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime > master > > > File Attachments > ---------------- > > git-log-doc-kcontrol.output > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output > kio-log-docs.txt > > https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/911e5e67-3094-4d47-aa94-95129f5545fe__kio-log-docs.txt > > > Thanks, > > Burkhard Lück > >
