----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129880/#review102391 -----------------------------------------------------------
Fix it, then Ship it! Just one nitpick reamaining, please change and commit. You don't have to update this review request again. doc/katepart/development.docbook (line 245) <https://git.reviewboard.kde.org/r/129880/#comment68304> You mean $USERPROFILE% instead of %USER% :-) - Dominik Haumann On Jan. 26, 2017, 9:28 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129880/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 9:28 p.m.) > > > Review request for Documentation and Kate. > > > Repository: kate > > > Description > ------- > > bump date + releaseinfo in katepart > adapt to changes using the frameworks syntax-highlighting (no *xml installed, > compiled into a library) > fix location of language.xsd, afaik no longer installed > > some questions still remain, see FIXMEs in diff: > > * location of custom syntax-highlighting definition files on Windows? > > * validation of custom *.xml syntax-highlighting definition files works using > "validatehl.sh mySyntax.xml" ? > you need language.xsd running validatehl.sh but both validatehl.sh + > language.xsd are not installed building syntax-highlighting > and only available in the syntax-highlighting repo on commits.kde.org > > > Diffs > ----- > > doc/kate/plugins.docbook 7409b6d > doc/katepart/development.docbook 3c106bb > doc/katepart/index.docbook 83a22ad > > Diff: https://git.reviewboard.kde.org/r/129880/diff/ > > > Testing > ------- > > checkXML5 > > > Thanks, > > Burkhard Lück > >
