i.Dark_Templar added a comment.
After fixing bug 399274, the issue this change fixes becomes masked, but it still remains. It's hard to hit the issue now, maybe even impossible at the moment. But it might reappear later. For example, if removal of duplicate submenus is reworked into an option (and disabled) or removed, this issue would reappear. Or if there would appear a menu item with a fragment set in contents tree (url://example#fragment), or multiple such items with same base url and different fragment (url://example#fragment2, url://example#fragment3, etc), and at the same time no menu item having corresponding url with empty fragment would exist in that tree (no "url://example"), in that unlikely case menu items deduplication wouldn't work and this issue would reappear too. Those are two theoretic scenarios I can imagine at the moment which would be fixed by this change. REPOSITORY R125 KHelpCenter REVISION DETAIL https://phabricator.kde.org/D16057 To: pavelmos, yurchor, ltoscano Cc: i.Dark_Templar, kde-doc-english, skadinna
