aacid added a comment.

  I *have not tried* it.
  
  I think the code is in good enough shape now.
  
  If you're confident with your testing is good enough, for me you can commit 
it (with the const fix)
  
  If you want someone else to give it a test say so and i'll test it a bit.

INLINE COMMENTS

> view.cpp:3689
>  
> +QRectF View::getViewport()
> +{

this function should probably be const

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17120

To: yurchor, #kde_edu, tcanabrava
Cc: cfeck, aacid, tcanabrava, kde-edu, kde-doc-english, skadinna, narvaez, apol

Reply via email to