tcanabrava added inline comments. INLINE COMMENTS
> maindlg.cpp:703-704 > + prt.setResolution( 72 ); > + QPointer<QPrintPreviewDialog> preview = new QPrintPreviewDialog( &prt ); > + QPointer<KPrinterDlg> printdlg = new KPrinterDlg( m_parent ); > + QList<QToolBar *> toolbarlist = preview->findChildren<QToolBar *>(); If you are creating them here to delete them in the end of the function, why don't you create them on the stack? > maindlg.cpp:735-736 > + preview->exec(); > + delete printdlg; > + delete preview; > +} create them on the stack do you don't need to call delete. REPOSITORY R334 KmPlot REVISION DETAIL https://phabricator.kde.org/D17626 To: yurchor, #kde_edu Cc: tcanabrava, kde-doc-english, kde-edu, skadinna, narvaez, apol
