arrowd accepted this revision. arrowd added a comment. This revision is now accepted and ready to land.
In D17278#386387 <https://phabricator.kde.org/D17278#386387>, @dmensinger wrote: > I also don't know why the icons don't show up. I have oriented myself on the code from the CMake plugin, and I don't know what I am doing different/wrong. Maybe KDevelop has to be installed in a system directory (/usr) for this to work? Yep, probably. This isn't blocker anyways. I've tested some basic scenarios and it at least doesn't crash. I'd say this can be pushed. Let's wait for a couple of days first, though. REPOSITORY R32 KDevelop BRANCH meson_initial_phabricatorSucks (branched from master) REVISION DETAIL https://phabricator.kde.org/D17278 To: dmensinger, apol, arrowd Cc: arrowd, rjvbb, flherne, rizzitello, yurchor, kde-doc-english, kdevelop-devel, glebaccon, hase, antismap, iodelay, skadinna, geetamc, Pilzschaf, akshaydeo, surgenight
