elvisangelaccio added a comment.
In D19770#453747 <https://phabricator.kde.org/D19770#453747>, @ngraham wrote: > In D19770#453371 <https://phabricator.kde.org/D19770#453371>, @elvisangelaccio wrote: > > > I still think that the rename from "Search" to "Find" should be done either upstream/globally or not at all. > > > > Anyway, it's unrelated from this commit, which is just about moving to placeholders everywhere (which I agree with). > > > Search and Find have different meanings because they do different things: locating files or items that match the given text in a data set of indeterminate or unclear size is "Search"; locating instances of text within the open document or page is "Find". But they should both have the same common [ctrl] + [F] keyboard shortcut. So it cannot be done globally. > > Any idea how we move forward with this? Fair enough. Another thing I didn't consider is that the menubar is hidden by default, so most dolphin users probably never even see the text of the search action. @ognarb Please rename the variables as mentioned inline and then we can ship it. INLINE COMMENTS > dolphinmainwindow.cpp:932 > + // Overwrite Find action to Search action > + QAction *search = > ac->action(KStandardAction::name(KStandardAction::Find)); > + search->setText(i18n("Search...")); Please call this variable `searchAction`. > dolphinmainwindow.cpp:1144 > > - KStandardAction::find(this, &DolphinMainWindow::find, > actionCollection()); > + QAction *search = KStandardAction::find(this, &DolphinMainWindow::find, > actionCollection()); > + search->setText(i18n("Search...")); And this one too. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D19770 To: ognarb, #dolphin, #vdg, ngraham, elvisangelaccio Cc: GB_2, kde-doc-english, elvisangelaccio, ngraham, yurchor, kfm-devel, gennad, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
