ngraham added a comment.
In D23415#519911 <https://phabricator.kde.org/D23415#519911>, @zzag wrote: > > Also I don't think renaming the enums is a good idea: > > > > - If the point is to retain naming consistency throughout the codebase, then we'd need to update the strings written to and read from the config files as well, which would necessitate a kconf update script, which seems like total overkill; no other KDE project imposes such a high bar for simple string changes > > - If, to avoid the above, we just rename the enums but not all occurrences in the codebase, then we haven't actually maintained consistency, and there's no point in doing any code renaming at all > > I didn't say to touch serialized config values. I said only to adjust enum names. that's it. But that doesn't make sense to me. The reason to rename it in the code as well is to preserve internal consistency with the user-displayed strings. If we only rename the enums and not the serialized values, we're not actually doing that, so what's the point? In D23415#519911 <https://phabricator.kde.org/D23415#519911>, @zzag wrote: > This placement policy has been called "smart" for two decades. Many people are used to this name and I don't want to change things for old-school or current users. This string is buried in the Advanced tab of an infrequently-used KCM. Bad strings should be improved, even if they've been bad for 20 years. Otherwise they'll be bad for another 20 years. I really don't understand why this is controversial. No other KDE project seems imposes so high a bar on simple string changes. In D23415#519911 <https://phabricator.kde.org/D23415#519911>, @zzag wrote: > I get your point about the name not being very descriptive but if you really want to make these names intuitive, then there should be some demo along the placement policy combobox in the kcm. That's not necessary if the names themselves are descriptive. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23415 To: ngraham, #kwin, #vdg, ndavis, filipf, zzag Cc: romangg, cfeck, filipf, zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
