broulik added inline comments. INLINE COMMENTS
> dolphinui.rc:2 > <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd"> > -<kpartgui name="dolphin" version="22"> > +<kpartgui name="dolphin" version="23"> > <MenuBar> Careful, this clashes with the recent toolbar shuffling > dolphinview.cpp:1351 > + default: mode = ViewModeSettings::IconsMode; > + Q_ASSERT(false); > + break; `Q_UNREACHABLE();` Why bother having a `default` case, though? > dolphinview.cpp:1355 > + const ViewModeSettings settings(mode); > + QSize iconSize = QSize(settings.iconSize(), settings.iconSize()); > + setZoomLevel(ZoomLevelInfo::zoomLevelForIconSize(iconSize)); `const` REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22444 To: ngraham, elvisangelaccio, shubham, #dolphin Cc: broulik, cfeck, kfm-devel, kde-doc-english, aprcela, vmarinescu, fprice, gennad, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
