pdabrowski added inline comments. INLINE COMMENTS
> broulik wrote in dolphinmainwindow.cpp:943 > `exec()` on a job is generally bad, but looks like it was like this already? Yes, it was like that in DolphinMainWindow::openTerminal() before. It was needed as explained in this comment: // If the given directory is not local, it can still be the URL of an // ioslave using UDS_LOCAL_PATH which to be converted first. > broulik wrote in dolphinmainwindow.cpp:2289 > This causes quite severe bug https://bugs.kde.org/show_bug.cgi?id=420911 > Why is this needed anyway, we already monitor `aboutToShow` for all the > relevant menus, no? It was added to handle this action as a button in toolbar (can be added by user, and this was requested in #384798). I didn't notice this causes such a problem with remote connections, sorry. It is a rare occasion that user changes preferred search tools, but I guess they would like to have it updated all over Dolphin when they do. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D22594 To: pdabrowski, #dolphin, ngraham, elvisangelaccio Cc: broulik, pkloc, kfm-devel, kde-doc-english, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, rdieter, mikesomov
